-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set devel v0.2.1-9000 #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* require namespace of "raster" -- so that we can eventually move "raster" from Imports to Suggests - updated: `read_netCDF_as_raster()`, `get_xyspace()` - `read_netCDF(): wrap example code that uses "raster" in a require namespace condition * example code and unit tests uses "terra" instead of "raster" where possible * `get_xyspace()` can now handle "SpatRaster" ("terra" class) input * `create_example_netCDFs()` uses "terra" instead of "raster" to create examples
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 78.90% 78.90% -0.01%
==========================================
Files 7 7
Lines 1721 1730 +9
==========================================
+ Hits 1358 1365 +7
- Misses 363 365 +2 ☔ View full report in Codecov by Sentry. |
- "consecutive_stopifnot_linter" renamed to "consecutive_assertion_linter" - [unreachable_code_linter] Code inside a conditional loop with a deterministically false condition should be removed - [unnecessary_nested_if_linter] Don't use nested `if` statements, where a single `if` with the combined conditional expression will do. For example, instead of `if (x) { if (y) { ... }}`, use `if (x && y) { ... }`. - [keyword_quote_linter] Only quote named arguments to functions if necessary, i.e., if the name is not a valid R symbol (see ?make.names). - [if_not_else_linter] In a simple if/else statement, prefer `if (A) x else y` to the less-readable `if (!A) y else x`. - [implicit_assignment_linter] Avoid implicit assignments in function calls. For example, instead of `if (x <- 1L) { ... }`, write `x <- 1L; if (x) { ... }`. - [indentation_linter] Indentation should be 8 spaces but is 6 spaces - [scalar_in_linter] Use == to match length-1 scalars, not %in%. Note that == preserves NA where %in% does not.
- `as_points()`: now converts from/to "SpatVector" - "sp" package is loaded via `requireNamespace()` if needed
…ate_nominal_resolution() - switched algorithms, examples and unit tests from using "raster" package to "terra" and/or "stars" packages instead - "RasterLayer" inputs are converted to "terra"'s "SpatRaster" (for now) - small deviation in output from previous version due to new algorithms - new (suggested) package dependencies on "lwgeom" and "units" for dealing with "stars" objects
- read_netCDF() can now use the "terra" package
-> make "raster" a "suggested" package
Use "terra" and "sf" packages instead of "raster" or "sp" - addressing #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.