Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set devel v0.2.1-9000 #23

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Set devel v0.2.1-9000 #23

merged 10 commits into from
Dec 5, 2023

Conversation

dschlaep
Copy link
Member

@dschlaep dschlaep commented Dec 4, 2023

No description provided.

* require namespace of "raster" -- so that we can eventually move "raster" from Imports to Suggests
    - updated: `read_netCDF_as_raster()`, `get_xyspace()`
    - `read_netCDF(): wrap example code that uses "raster" in a require namespace condition

* example code and unit tests uses "terra" instead of "raster" where possible

* `get_xyspace()` can now handle "SpatRaster" ("terra" class) input

* `create_example_netCDFs()` uses "terra" instead of "raster" to create examples
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (aaa1889) 78.90% compared to head (624fca6) 78.90%.

❗ Current head 624fca6 differs from pull request most recent head 1d6b9a4. Consider uploading reports for the commit 1d6b9a4 to get more accurate results

Files Patch % Lines
R/functions_netCDF.R 87.67% 9 Missing ⚠️
R/functions_geographical.R 91.78% 6 Missing ⚠️
R/conversions.R 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   78.90%   78.90%   -0.01%     
==========================================
  Files           7        7              
  Lines        1721     1730       +9     
==========================================
+ Hits         1358     1365       +7     
- Misses        363      365       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dschlaep and others added 8 commits December 4, 2023 09:55
- "consecutive_stopifnot_linter" renamed to "consecutive_assertion_linter"

- [unreachable_code_linter] Code inside a conditional loop with a deterministically false condition should be removed
- [unnecessary_nested_if_linter] Don't use nested `if` statements, where a single `if` with the combined conditional expression will do. For example, instead of `if (x) { if (y) { ... }}`, use `if (x && y) { ... }`.
- [keyword_quote_linter] Only quote named arguments to functions if necessary, i.e., if the name is not a valid R symbol (see ?make.names).
- [if_not_else_linter] In a simple if/else statement, prefer `if (A) x else y` to the less-readable `if (!A) y else x`.
- [implicit_assignment_linter] Avoid implicit assignments in function calls. For example, instead of `if (x <- 1L) { ... }`, write `x <- 1L; if (x) { ... }`.
- [indentation_linter] Indentation should be 8 spaces but is 6 spaces
- [scalar_in_linter] Use == to match length-1 scalars, not %in%. Note that == preserves NA where %in% does not.
- `as_points()`: now converts from/to "SpatVector"
- "sp" package is loaded via `requireNamespace()` if needed
…ate_nominal_resolution()

- switched algorithms, examples and unit tests from using "raster" package to "terra" and/or "stars" packages instead
- "RasterLayer" inputs are converted to "terra"'s "SpatRaster" (for now)

- small deviation in output from previous version due to new algorithms
- new (suggested) package dependencies on "lwgeom" and "units" for dealing with "stars" objects
- read_netCDF() can now use the "terra" package
-> make "raster" a "suggested" package
Use "terra" and "sf" packages instead of "raster" or "sp"

- addressing #18
@dschlaep dschlaep merged commit bd765ab into main Dec 5, 2023
14 checks passed
@dschlaep dschlaep deleted the release/devel_v0.2.1 branch December 5, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant